Inlining review and fact check activity fields #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,2 +1,6 @@ | |||
| <% render_activity_forms ||= false %> | |||
There was a problem hiding this comment.
styleguide says booleans shouldn't be initialised with ||=. How about render_activity_forms = false unless defined?(:render_activity_forms) instead?
There was a problem hiding this comment.
good catch! amended in 7649d01
added 3 commits
September 10, 2014 11:07
www.agileplannerapp.com/boards/173808/cards/5629 ... with edition form. these were left out earlier, causing review activities to not save edition changes. part of a larger change: #251
this template is not being used anywhere. instead shared/_review gets rendered. looks like it was left behind when common templates were moved to the shared folder.
Poltergeist is seeing '.help-block' overlapping
the 'Save' button, hence can't click it without
a `.trigger('click')` on that element.
This needs to be followed by an assertion that
waits for the edition to get saved, or else
capybara jumps to the next statement.
9e50049 to
19f931a
Compare
ec74737 to
b79c851
Compare
.. and moving locals logic into a helper, so that we don't have to pass locals around to detect the diff view.
b79c851 to
a17e7b0
Compare
|
👍 |
vinayvinay
added a commit
that referenced
this pull request
Sep 10, 2014
…edback Inlining review and fact check activity fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as part of a larger change we inlined all activity fields with the edition form, so that activities and edition changes get submitted in one go. we missed inlining review and fact check activities. so this covers up for that.
also removed an unnecessary template
programmes/_review.html.erb, and fixed integrations tests failing due to poltergeist getting confused with overlapping elements.