Correcting Bundler.require in application.rb #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had deviated from the standard Rails 3.2.x Bundler.require directive. When we upgraded to the latest version of bootstrap-sass, Publisher deploys started failing during assets precompilation: govuk_setenv publisher bundle exec rake \ RAILS_ENV=production RAILS_GROUPS=assets \ assets:precompile @alext pointed this out, and suggested this change to keep configs consistent with other Rails 3.2.x apps.
1b893fe to
2bcd669
Compare
alext
added a commit
that referenced
this pull request
Sep 8, 2014
Correcting Bundler.require in application.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had deviated from the standard Rails 3.2.x
Bundler.requiredirective. When we upgraded to the latest version of bootstrap-sass, Publisher deploys started failing during assets precompilation:govuk_setenv publisher bundle exec rake \ RAILS_ENV=production RAILS_GROUPS=assets \ assets:precompile@alext pointed this out, and suggested this change to keep configs consistent with other Rails 3.2.x apps.