Add puma via govuk_app_config #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is currently failing as end-to-end tests are trying to run |
1d13f9b to
cf4c799
Compare
This commit adds `Puma` via govuk_app_config. Puma was previously installed indirectly through the dependency on `govuk_test` as part of the `dev` and `test` groups; given that we want to run Puma in production, we are instead configuring it via govuk_app_config. Co-authored-by: Chris Banks <chris.banks@digital.cabinet-office.gov.uk>
bilbof
approved these changes
Oct 27, 2021
sengi
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Pumavia govuk_app_config. Puma was previously installed indirectly through the dependency ongovuk_testas part of thedevandtestgroups; given that we want to run Puma in production, we are instead configuring it via govuk_app_config.This PR is reliant on changes to govuk_app_config
Trello card