Pp 13499 add transformation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract most values once from the CloudWatch log event since they are the same for each log event message.
Move most test data into fixtures and then dynamically generate FirehoseTransformationEvent input when the input doesn't matter so much, e.g. testing error scenarios.
* Changed errors within a record to only fail processing of a single record and continue the others. * Fixed index of s3 logs * Used official types for the CloudWatchLogsDecodedData * Made service field in splunk fields optional Co-authored-by: Dan Worth <dan.worth@digital.cabinet-office.gov.uk>
jfharden
approved these changes
Feb 6, 2025
kbottla
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move most test data into fixtures and then dynamically generate FirehoseTransformationEvent input when the input doesn't matter so much, e.g. testing error scenarios.
Also some minor formatting and minor refactor of the transformation to make it a little more efficient (in first commit)