PP-13499 VPC flow logs #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves dropping of messages closer the processing of CloudWatch logs to make it simpler to drop vpc-flow-logs in future.
Refactor to permit filtering of individual log lines within an event record. Following existing filtering VPC flow logs will only be sent to Splunk if the connection was accepted and not using TCP, UDP or ICMP protocols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to permit filtering of individual log lines within an event record. Following existing filtering VPC flow logs will only be sent to Splunk if the connection was accepted and not using TCP, UDP or ICMP protocols.
NOTES
Based upon this existing logic for filtering out vpc flow logs: https://github.com/alphagov/pay-cloudwatch-logs-s3-export/blob/main/exports.js#L119