Implement InsensitiveSet.__contains__
#1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85e3277 to
b3ef620
Compare
I was suprised that `"first name" in InsensitiveSet(['firstname'])` evaluated to `False`. This commit makes it work the way you’d expect. We don’t use this in production code yet, but don’t think it can hurt.
b3ef620 to
b1da482
Compare
rparke
approved these changes
Feb 26, 2025
|
This is the first time I've noticed |
|
@risicle yeah it’s not used that widely. Think the only place at the moment is here: https://github.com/alphagov/notifications-admin/blob/2fc712d52176ddfc6ef3546fb42759614a1eca27/app/main/views/send.py#L806-L820 PRs to make it more correct welcome… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised that
"first name" in InsensitiveSet(['firstname'])evaluated toFalse.This commit makes it work the way you’d expect.
We don’t use this in production code yet, but don’t think it can hurt.