Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two HMRC banners 2025/02/13 #54

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Add two HMRC banners 2025/02/13 #54

merged 2 commits into from
Feb 4, 2025

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented Feb 3, 2025 •
edited
Loading

What

Add two HMRC banners, both with the same contents and the same start date (2025/02/13) and end date (2025/03/13), but different links.

Why

Trello card

@unoduetre unoduetre force-pushed the 3228-put-live-govuk-user-research-banner-hmrc-ines branch from fba0373 to c12cb35 Compare February 4, 2025 09:50
@unoduetre unoduetre marked this pull request as ready for review February 4, 2025 09:57
@unoduetre unoduetre changed the title Add two HMRC banners 13/02/2025 Add two HMRC banners 2025/02/13 Feb 4, 2025
catalinailie
catalinailie approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@catalinailie catalinailie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ⭐

@unoduetre unoduetre merged commit 68ae473 into main Feb 4, 2025
10 checks passed
unoduetre added a commit that referenced this pull request Feb 4, 2025
@unoduetre
Release 1.0.0
0fabf7f 
* Add global banner JS to js dependencies file ([PR #55](#55))
* Add global banner support ([PR #34](#34))
* Remove configuration for "HMRC banner 03/01/2025" ([PR #53](#53))
* Gem updates ([PR #50](#50))
* Add two HMRC banners 13/02/2025 ([PR #54](#54))
@unoduetre unoduetre mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinailie catalinailie catalinailie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unoduetre @catalinailie