Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .ruby-version #74

Closed
wants to merge 3 commits into from
Closed

Update .ruby-version #74

wants to merge 3 commits into from

Conversation

MuriloDalRi
Copy link
Contributor

No description provided.

.ruby-version Outdated
@@ -1 +1 @@
3.0.5
3.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the lowest ruby version supported by the gem (as per: https://docs.publishing.service.gov.uk/manual/publishing-a-ruby-gem.html#ruby-version-compatibility)

so if this gem still supports Ruby 3.0 then this should be 3.0.6.

As we're adding 3.3 support we should probably drop 3.0 support and move the minimum version to be 3.1, which would mean this should be 3.1.4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my mistake!

@MuriloDalRi MuriloDalRi force-pushed the upgrade-ruby-version branch 2 times, most recently from f0350dd to 2119253 Compare February 12, 2024 10:37
@MuriloDalRi MuriloDalRi marked this pull request as draft February 23, 2024 11:01
@MuriloDalRi MuriloDalRi deleted the upgrade-ruby-version branch February 26, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants