Add component wrapper helper to the header #4385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33694aa to
ad9d1ba
Compare
andysellick
reviewed
Nov 14, 2024
| @@ -14,9 +14,17 @@ | |||
| header_classes = %w[gem-c-layout-header govuk-header] | |||
| header_classes << "gem-c-layout-header--#{environment}" if environment | |||
| header_classes << "gem-c-layout-header--no-bottom-border" if remove_bottom_border | |||
|
|
|||
| component_helper = GovukPublishingComponents::Presenters::ComponentWrapperHelper.new(local_assigns) | |||
There was a problem hiding this comment.
Can the lines above for header_classes be removed now?
There was a problem hiding this comment.
Whoops, good spot, have removed.
ad9d1ba to
c8137c4
Compare
c8137c4 to
c10f22a
Compare
andysellick
approved these changes
Nov 14, 2024
c10f22a to
33f18fa
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
layout_headercomponent.Why
As the trello card states:
Visual changes
None.