Allow aria-controls attribute on search component #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c87ea1 to
49ae5bc
Compare
49ae5bc to
474a3e9
Compare
This is adding the ability to specify the aria-controls attribute, that's available on the input component. Why On finders we are looking to upgrade the text input with a search icon to a search component. The latter is currently missing this attribute which is being used to announce dynamic changes.
474a3e9 to
16d75ad
Compare
alex-ju
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is adding the ability to specify the
aria-controlsattribute, that's available on the input component.Why
On finders we are looking to upgrade the text input with a search icon to a search component.
The latter is currently missing this attribute which is being used to announce dynamic changes.
View Changes
https://govuk-publishing-compo-pr-1203.herokuapp.com/component-guide/search