-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component print styles #1164
Conversation
- search component is not useful when printed, so hiding entirely
- only a minor change, hides the menu button
- hide the icon
- hide it entirely
- buttons looked quite different depending on whether they were links or buttons and what size they were - making all of them look consistent on print now, same font size, black outline, no arrows
a825f33
to
ae47b35
Compare
Is is worth adding in a style to add the address to links?
Source: Improving Link Display for Print |
@injms I believe that's already implemented by static - it happens on the live site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion for the character count component - but other than that tiny thing I think this looks a great improvement.
- tidy them up a bit, make them wider and shorter and put label, hint, error on separate lines
- hide everything apart from the OGL text and crown copyright line
- hide toggle control and show all updates link
- just hide it
- hide them
- hide them
ae47b35
to
cf60fd6
Compare
What
We seem to be missing some print stylesheets for some components, where print styles would be sensible. This PR adds some.
Why
People print pages on GOV.UK.
Visual Changes
Screenshots are a bit pointless because most of these changes involve hiding things, but here's a summary.
Things I've not added print styles for:
Screenshots
View Changes
https://govuk-publishing-compo-pr-1164.herokuapp.com/component-guide
This PR is related to alphagov/govuk-frontend#573