Add new section for file upload, with examples #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure both examples have their own snippets - Do not style the input, leave as native control - Show how errors look with this input
|
Looks good, I wonder if we should put an explanation on why we are not doing a custom upload as I imagine some people will see this as an opportunity to re-implement it without realising the effort we need to go into to making sure a custom input behaves as well as a native input? |
|
I've added a section underneath to explain why we recommend using the native Screenshot below:
|
|
Thanks Gemma 👍 |
| <li>the control gains focus when tabbing through the page</li> | ||
| <li>the control functions using a keyboard</li> | ||
| <li>the control functions using assistive technology</li> | ||
| <li>the control functions when javascript is disabled</li> |
There was a problem hiding this comment.
should we generally refer to 'javascript is not available', given the majority case is not 'disabled'
There was a problem hiding this comment.
Yup, absolutely - feel free to open a PR to fix!
gemmaleigh
pushed a commit
that referenced
this pull request
Jun 8, 2017
0.22.0 - Adds new Apple touch icons to precompile list for Rails apps [PR #305](alphagov/govuk_template#305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does the pull request solve?
This PR fixes #298, by reverting the custom file upload style.
What does it do?
The button style currently used prevents the button from gaining focus.
This a bug, for now it is better to revert to the native file upload and in future find a custom solution which is accessible.
Screenshots (if appropriate):
Before:
After:
After (focussed by tabbing through form examples page):
New section added to the "Form elements" guide:
What type of change is it?