Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borders on inputs have low contrast if colours adjusted by user #297

Closed
edwardhorsford opened this issue Aug 30, 2016 · 3 comments
Closed

Borders on inputs have low contrast if colours adjusted by user #297

edwardhorsford opened this issue Aug 30, 2016 · 3 comments
Labels
in progress

Comments

@edwardhorsford
Copy link
Contributor

edwardhorsford commented Aug 30, 2016 •
edited
Loading

If a user adjusts their colours (for accessibility / readability), many bits of elements colours change, but input borders don't (in firefox at least). Similarly, buttons become invisible, as do warning graphic icons.

Screenshot:
screen shot 2016-08-30 at 12 30 05

How would you expect it to work?

It would be great if the borders adjusted with text colour. It looks like other graphic elements do change - such as the 'examples' border.

How does it work currently?

The border of inputs does not change.

Feel free to suggest a fix...

Might not have a fix - but raising an issue in case it can be improved.

Tested after re-reading this blog post:

Explain the steps to reproduce the bug

Use firefox to adjust text and background colours.
@edwardhorsford
Copy link
Contributor Author

More examples:
screen shot 2016-08-30 at 12 34 55
screen shot 2016-08-30 at 12 35 15

@gemmaleigh
Copy link
Contributor

#296 fixes this, these will now inherit $text-colour, so they can be overridden.

gemmaleigh added a commit that referenced this issue Oct 11, 2016
@gemmaleigh
Bump govuk frontend toolkit to 4.15.0
636ff66 
4.15.0

alphagov/govuk_frontend_toolkit@620c7fdb1eca75
cfb7a8c076cafcf50852a85008

Add support for Google Analytics fieldsObject (PR #298)

anchor-buttons.js: normalise keyboard behaviour between buttons and
links with a button role (PR #297)
@robinwhittleton
Copy link
Contributor

Fixed by #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robinwhittleton @gemmaleigh @edwardhorsford