Publish v3.3.0 which fixes broken data_sync_excluded_exceptions behaviour
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 3.1.0/3.1.1 we merged the `should_capture` method into the `before_send` method in preparation for swapping out `sentry-raven` for `sentry-ruby`. However, it broke the "ignore certain errors when they happen during the data sync" behaviour. This is subsequently fixed in v4, but not all apps can/will be upgraded to v4, so we should offer a stable v3.
This will be published manually by following https://docs.publishing.service.gov.uk/manual/publishing-a-ruby-gem.html#manually-publishing-gems-from-the-cli
f740941 to
b151cd1
Compare
b151cd1 to
48c6711
Compare
data_sync_excluded_exceptions behaviour
benjamineskola
approved these changes
Jul 2, 2021
1pretz1
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.3.0 reverts changes introduced in 3.1.0 and 3.1.1. In 3.1.0/3.1.1 we merged the
should_capturemethod into thebefore_sendmethod in preparation for swapping outsentry-ravenforsentry-ruby. However, it broke the "ignore certain errors when they happen during the data sync" behaviour.This is subsequently fixed in v4, but not all apps can/will be upgraded to v4, so we should offer a stable v3.
I've manually published v3.3.0 from the command line, and then merged
maininto this branch as the last commit, to retain the history.Trello: https://trello.com/c/lVDo5gTD/2603-remove-beforesend-shouldcapture-changes-in-govukappconfig-v330