Add Speedcurve's LUX to connect-src policy #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107ae72 to
71ac022
Compare
richardTowers
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Thanks! Looks good.
Might be worth mentioning in the commit message that this is needed in both the image-src and connect-src bits of the policy because we load the speedcurve payload through an <img src="">, but it's served with a non-image content type (application/javascript).
71ac022 to
152f908
Compare
richardTowers
approved these changes
Jun 16, 2021
Closed
injms
added a commit
that referenced
this pull request
Nov 10, 2021
injms
added a commit
that referenced
this pull request
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the domain name that Speedcurve's LUX is using for real user metics - this allows LUX to report on how a page is performing.