Update to GOV.UK Frontend 3.0.0 #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34a1f99 to
3c3b5f7
Compare
aliuk2012
approved these changes
Jul 19, 2019
c5f154d to
ae7644d
Compare
36degrees
reviewed
Jul 19, 2019
| @@ -5,7 +5,7 @@ | |||
| .app-step-nav-header { | |||
| position: relative; | |||
| padding: 10px; | |||
| background: govuk-colour("grey-4"); | |||
| background: govuk-colour("light-grey"); | |||
There was a problem hiding this comment.
I wonder if we want to pass $legacy attributes here so that users can opt to use the legacy palette and this won't blow up?
Include legacy colours if a user turns on the legacy palette
Icon is now an inline SVG
ae7644d to
92726f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request establishes the base for the upcoming Prototype Kit 9.0 release which'll include GOV.UK Frontend 3.0.0.
I followed the release notes for 3.0.0 to do this pull request.
It has a pre-release installed which will be changed when we're ready to release this properly.