This repository was archived by the owner on Jul 17, 2018. It is now read-only.
Update to use GOV.UK Frontend 0.0.25 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace removed $govuk-highlight-colour with $govuk-grey-4, $govuk-page-colour with $govuk-white.
joelanman
suggested changes
Mar 7, 2018
|
@joelanman done! |
|
Frontend 0.0.23 added a fix for lists which means the old override class fix is conflicting: |
joelanman
reviewed
Mar 7, 2018
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| # Unreleased | |||
|
|
|||
| New features: | |||
There was a problem hiding this comment.
I think it'd be a breaking change, considering Frontend has breaking changes
Good catch 👍 |
Frontend 0.0.23 added a fix for lists [1] which means that the padding top override class is no longer required. [1]: https://github.com/alphagov/govuk-frontend/blob/master/CHANGELOG.md#0023-alpha-breaking-release
4380172 to
fc4a9f0
Compare
|
@joelanman can you re-review please? |
joelanman
approved these changes
Mar 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$govuk-highlight-colour,$govuk-page-colour)govuk-emfunctionform-classdiv around button on check your answers pagehttps://trello.com/c/q9Rq7nNf/799-update-pk-to-use-the-new-frontend-release