This repository was archived by the owner on Jul 17, 2018. It is now read-only.
Add hack to check node_modules exists #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only needed because we are vendoring private govuk-frontend
|
nice, thanks. Wondering if we should start updating the Changelog with each PR, same as Fronted/Design system. Seems like a good approach |
|
Updated changelog |
3d42fc1 to
6093723
Compare
6093723 to
34075c7
Compare
joelanman
approved these changes
Feb 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only needed because we are vendoring private govuk-frontend
This PR is done with a prototyping hat on, since we intend to delete this project once we've finished our private beta work, otherwise I would not be happy with this hack.
Let me know if this is OK.
As part of https://trello.com/c/mBYUk8Bx/680-fix-npm-install-warning-in-the-prototype-kit-beta