Remove anchor styling in govuk-lists #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This need can be satisfied by enabling global styles, which is on by default in the GOV.UK Prototype Kit. I have checked our [documentation](https://design-system.service.gov.uk/styles/typography/#lists) and we do not recommend our users do this. With this both in mind this feels reasonable to remove this functionality as a breaking change.
36degrees
approved these changes
Sep 6, 2018
36degrees
reviewed
Sep 6, 2018
| @@ -103,6 +103,16 @@ | |||
| ``` | |||
| ([PR #981](https://github.com/alphagov/govuk-frontend/pull/981)) | |||
|
|
|||
| - Remove anchor styling in govuk-lists | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These styles partially implement the
.govuk-linkstyles, but fail to implement the correct focus styles.Additionally this need can be satisfied by enabling global styles, which is on by default in the GOV.UK Prototype Kit.
I have checked our documentation and we do not recommend our users do this.
With this both in mind this feels reasonable to remove this functionality as a breaking change, without a deprecation period.