Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tabs spacing #886

Merged
merged 3 commits into from
Jul 16, 2018
Merged

Update tabs spacing #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7847bdd
Adjust internal padding of tab content and margin on mobile breakpoint
Jul 12, 2018
2d88095
Use :last-child to remove the margin of the last item in the tab content
Jul 12, 2018
e2523fc
Update CHANGELOG for tabs spacing changes
NickColley Jul 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@
🔧 Fixes:

- Update details behaviour to remove margin-bottom for all elements

([PR #900](https://github.com/alphagov/govuk-frontend/pull/900))

- Update internal padding of tab content in the tabs component
([PR #886](https://github.com/alphagov/govuk-frontend/pull/886))

## 1.1.0 (feature release)

🆕 New features:
Expand Down
13 changes: 11 additions & 2 deletions src/components/tabs/_tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
padding: 0;
list-style: none;
@include mq($until: tablet) {
@include govuk-responsive-margin(2, "bottom");
@include govuk-responsive-margin(6, "bottom");
}
}

Expand Down Expand Up @@ -50,6 +50,10 @@
}
}

.govuk-tabs__panel {
@include govuk-responsive-margin(8, "bottom");
}

// JavaScript enabled
.js-enabled {

Expand Down Expand Up @@ -104,12 +108,17 @@
}

.govuk-tabs__panel {
@include govuk-responsive-margin(0, "bottom");
padding-top: govuk-spacing(6);
padding-right: govuk-spacing(4);
padding-bottom: govuk-spacing(2);
padding-bottom: govuk-spacing(6);
padding-left: govuk-spacing(4);
border: 1px solid $govuk-border-colour;
border-top: 0;

& > :last-child {
margin-bottom: 0;
}
}
}

Expand Down