Document assistive tech support in FE Readme #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
199c44a to
51800b0
Compare
36degrees
reviewed
Jun 15, 2018
README.md
Outdated
|
|
||
| In addition, we test that all content is accessible with keyboard only. | ||
|
|
||
| We also aim to support high contrast mode for those users who need to adjust browser colours to increase readability. We have in the past tested this by setting custom colours in Firefox (under Preferences), and with the [High Contrast][high-contrast] plugin. Read more about [how users change colours on websites][how-users-change-colours-on-websites]. |
There was a problem hiding this comment.
Suggest linking to Firefox's docs: https://support.mozilla.org/en-US/kb/change-fonts-and-colors-websites-use
There was a problem hiding this comment.
A couple of minor things with this paragraph…
- I don't think it's just high contrast mode we support
- We mention high contrast mode but don't talk about testing with it
- I think there's reasons that users would override that don't relate to readability (e.g. high constrast gives them migraines).
How about something like…
We aim to support users who adjust or override the colours of websites they visit. We test this by changing colours in Firefox, by enabling 'High Contrast' mode in Windows and by using the High Contrast plugin for Chrome.
README.md
Outdated
| @@ -77,6 +77,31 @@ include a separate stylesheet in order to support Internet Explorer | |||
|
|
|||
| [service-manual-browsers]: https://www.gov.uk/service-manual/technology/designing-for-different-browsers-and-devices#browsers-to-test-in | |||
|
|
|||
| ## Support for assistive technology | |||
There was a problem hiding this comment.
Given we have a heading called 'Browser support' can we follow form and go with 'Assistive technology support'?
README.md
Outdated
| GOV.UK Frontend will allow you to build services that comply with the [guidance | ||
| in the Service Manual][service-manual-assistive-technologies]. | ||
|
|
||
| Currently, GOV.UK Frontend officially supports the following assistive technology: |
There was a problem hiding this comment.
Should probably be 'technologies'
51800b0 to
456ca72
Compare
456ca72 to
75f4e68
Compare
75f4e68 to
e1a8d41
Compare
e1a8d41 to
2afd31f
Compare
2afd31f to
bbae906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets out the assistive technology that GOV.UK Frontend supports.
In the future, we would like to add guidance about writing accessibility acceptance criteria.
https://trello.com/c/hZD483RS/1030-document-assistive-tech-support-in-fe-readme