Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template updates: beforeContent, mainClasses, review application updates. #742

Merged
merged 4 commits into from
May 31, 2018
Merged

Template updates: beforeContent, mainClasses, review application updates. #742

merged 4 commits into from
May 31, 2018

Conversation

NickColley
Copy link
Contributor

  • Adds a beforeContent feature, for content that does not belong in the 'main' element.
  • Adds mainClasses, this is something that was missed in the original version, the main classes add padding to pages.

I made an oversight on how the review application templates work so this PR includes some clean up for that.

See individual commits.

NickColley added 3 commits May 31, 2018 14:54
@NickColley
Add beforeContent block
48b72a0 
Used for content that should not live within the main element.
For example, navigation style components.
@NickColley
Add main wrapper class
ed5a0ee 
Also allows adding the main wrapper variants with `mainClasses`
@NickColley
Fix review application templates to have correct structure
eb624c2
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-742 May 31, 2018 14:24 Inactive
36degrees
36degrees approved these changes May 31, 2018
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@NickColley NickColley merged commit 64d36f1 into master May 31, 2018
@NickColley NickColley deleted the template-updates branch May 31, 2018 15:17
36degrees added a commit that referenced this pull request May 31, 2018
@36degrees
Fix several issues with the changelog
a930de0 
- Add missing changelog entry for #743
- Correct PR numbers for #742
- Correct markdown syntax for PR links

🤦‍♂️
@36degrees 36degrees mentioned this pull request May 31, 2018
Merged
@hannalaakso hannalaakso mentioned this pull request Jun 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickColley @36degrees @govuk-design-system-ci