Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of IE8 issues #737

Merged
merged 3 commits into from
May 31, 2018
Merged

Fix a couple of IE8 issues #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47bd722
Fix missing breadcrumb chevrons in IE8
36degrees May 30, 2018
9bc6d96
Render button shadow as border in IE8
36degrees May 30, 2018
3e999ac
Document button change in CHANGELOG
36degrees May 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ Note: We're not following semantic versioning yet, we are going to talk about th
- Removed some duplicated CSS rules from the outputted CSS
([PR #727](https://github.com/alphagov/govuk-frontend/pull/727))

- Fixes a bug in IE8 where the button component did not have a shadow, by
rendering the shadow using a border for IE8 specifically – IE8 does not
support box-shadow
([PR #737])(https://github.com/alphagov/govuk-frontend/pull/737)


🆕 New features:

Expand Down
4 changes: 4 additions & 0 deletions src/components/breadcrumbs/_breadcrumbs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@
height: auto;
border: 0;
color: $chevron-border-colour;

// IE8 doesn't seem to like rendering pseudo-elements using @font-faces,
// so fall back to using another sans-serif font to render the chevron.
font-family: Arial, sans-serif;
}
}

Expand Down
8 changes: 8 additions & 0 deletions src/components/button/_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
cursor: pointer;
-webkit-appearance: none;

@include govuk-if-ie8 {
border-bottom: $button-shadow-size solid $govuk-button-shadow-colour;
}

@include mq($from: tablet) {
width: auto;
}
Expand Down Expand Up @@ -72,6 +76,10 @@
&:active {
top: $button-shadow-size;
box-shadow: none;

@include govuk-if-ie8 {
border-bottom-width: 0;
}
}

// The following adjustments do not work for <input type="button"> as
Expand Down