Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some duplication from CSS #727

Merged
merged 4 commits into from
May 29, 2018
Merged

Remove some duplication from CSS #727

merged 4 commits into from
May 29, 2018

Conversation

36degrees
Copy link
Contributor

See individual commits for details.

36degrees added 3 commits May 29, 2018 16:32
The font-family is defined as part of the `govuk-link-common` mixin, so using `govuk-font-regular-16` means we get it twice. Using just the `govuk-typography-responsive` mixin gives us just the font-size, which is what we’re after.
Captions use the secondary text colour, so this gets overridden.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-727 May 29, 2018 15:35 Inactive
Copy link
Contributor

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@36degrees 36degrees merged commit 5bb66d6 into master May 29, 2018
@36degrees 36degrees deleted the remove-duplication branch May 29, 2018 15:50
@NickColley NickColley mentioned this pull request May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants