Remove -c -o -h layer prefixes #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
previously requested changes
Apr 11, 2018
4e59fda to
c60db94
Compare
c60db94 to
51369f3
Compare
51369f3 to
6f536c2
Compare
6f536c2 to
3f159be
Compare
3f159be to
4a48067
Compare
4a48067 to
1e01c5e
Compare
1e01c5e to
ea04a56
Compare
ea04a56 to
116a543
Compare
NickColley
approved these changes
Apr 12, 2018
|
|
c1dd4d9 to
bc41a6a
Compare
added 2 commits
April 13, 2018 09:30
In user research and in feedback from Private Beta partners we learned that users didn't really understand what -o, -c and -h prefixes stand for or why they're useful. They also introduced additional cognitive load when composing classes, having to remember which suffix the classname contains. As a result of this, we're removing these prefixes from our codebase.
bc41a6a to
778d150
Compare
|
good spot. updated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In user research and in feedback from Private Beta partners we learned that users didn't really understand what -o, -c and -h prefixes stand for or why they're useful.
They also introduced additional cognitive load when composing classes, having to remember which suffix the classname contains.
As a result of this, we're removing these prefixes from our codebase.
This PR:
src/filesTrello ticket: https://trello.com/c/vAitHnu7/863-2-remove-object-component-and-helper-layer-prefixes