Simplify legacy IE logic #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GOV.UK Frontend will not support IE6 or IE7 - we don’t test with those browsers, and we don’t provide any guidance on building stylesheets to target them. Removing these rules simplifies the codebase and allows us to simplify the ‘legacy IE’ logic by removing reference to versions.
Removing the $version check and updating the mixins to be specific to IE8 makes them easier to use and simplifies the codebase.
For consistency, introduce a negated helper that allows rules to be excluded when compiling to target IE8, rather than the current approach of referring to the setting directly.
Rather than relying on the user remembering to specify another setting when building a stylesheet that targets IE8, modify the media queries settings to use sensible defaults based on the value of `$govuk-is-ie8`. This means we need to ‘promote’ the `$govuk-is-ie8` variable to the settings layer so that we can include it before the media queries settings.
NickColley
approved these changes
Apr 5, 2018
Merged
|
Should we update legacy-ie.md based on these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$mq-responsive: false;in their IE8 stylesheet by setting this value based on$govuk-is-ie8.Recommend reviewing commit by commit.
I have validated that this change does not affect the generated CSS by running
npm run build:diston both the master branch and this branch, copying the generated files fromdist/cssand comparing the files: