-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM: Update GOV.UK Frontend to new colour palette #611
Conversation
change underline colours Update govuk-light-blue Update red, blue tints and mid grey
Update green and red hex value
Move yellow to UI colours section
fb2bc59
to
5e57e32
Compare
src/footer/_footer.scss
Outdated
@@ -5,9 +5,9 @@ | |||
$govuk-footer-background: $govuk-light-grey; | |||
$govuk-footer-border-top: $govuk-dark-grey; | |||
$govuk-footer-border: $govuk-border-colour; | |||
$govuk-footer-text: $govuk-dark-grey; | |||
$govuk-footer-text: #454a4c; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary change - Footer specific link colour will be updated later
just to add that the new blue has a 3.79:1 contrast with the body text colour, which means we won't need to underline blue links on white backgrounds to meet WCAG anymore |
I have concerns with some of these changes with regards to accessibility. I'm not in favour of the changes to focus, link or error colours. It would be good to get @aduggin's and other accessibility team members' views on the changes. I don't think this should be merged without further discussion. If this isn't the right place to discuss the changes, let me know where and I can comment there instead. Focus colourThis has reduced in contrast. It's gone from 1.64:1 down to 1.35:1. What's the reasoning for changing it? Link and error coloursBoth drop the contrast a fair amount. They're just within WCAG AA, but generally more contrast is better. The lower contrast limits where these colours can be used. Link contrast goes from 6.68:1 to 5.17:1 The new link and error colours fail contrast requirements when paired with Example of a link used a table header: It's unclear if the Visited linksIt would be good to do some research around these. Many won't know what they mean, but some will. Is it a useful feature to these users? What do we gain by taking it away? The changes are not so relevant for transactional services, but possibly very relevant to content-heavy / publication services. Other changesGlad to be moving away from the turquoise colour for the completion box. I'm slightly wary of this starting to look quite buttony though. If a service has smaller or less text, will it still work? (I suspect it's fine, but would be good to check). Lightening the footer background seems sensible. Focused link colours - no opinion. Button colour - no opinion. |
With the visited colour being the same as the hover colour, could this cause confusion? |
The new focus colour looks like it has better contrast against the text, which is nice. However the contrast against the background white is lowered to 1.35:1. The old focus was 1.64:1 against white - both fail WCAG, but the new one is worse. (The new 2.1 WCAG guidance covers important graphics, as well as text). This is a particular problem, for example, seeing that a checkbox has focus. |
Hey all, overarching rationale to the changes; more contrast is better, but contrast between the background colours and text colours aren't the only factor - the text colours (black, blue, red and green) all need to have a high level of contrast from each other. At the moment, our colours have good contrast against white background, but awful contrast against each other. These changes are to fix that. Link colourThe new link colour passes AA colour contrast against the background colours, but also passes contrast requirements against the text colour - 3:1 - which our current link colour fails. WCAG G183 The panel colour should be replaced by light-grey, so again that's fine. Error colourDo any of our patterns use the error colour on panels? I'm not aware that they do Focus colour@joelanman you're right, the colour focus colour for the checkboxes and select boxes doesn't have good contrast. I was wondering about having a sort of ghost :checked style on them when focussed Visited colourThe previous visited colour was purple, which is definitely not an accessible difference from blue. I'm interested in ideas for having something that is accessible - maybe using :visited::content selector to write (visited) after visited links - but I think that does need more thought and testing. Until we've done that, having it the same colour as hover gives it a visual difference, and doesn't seem any accessible than the current visited state. |
There are issues with this behaviour – unchecking a checkbox will leave the element focussed, which means you will have unchecked it but it will still appear as if it is checked (albeit in a 'ghosted' fashion) until you move the focus to another element on the page. |
The focus contrast issue affect other elements too - for example buttons, text inputs, upload. I wonder if we should make our focus style just outline link text, instead of filling in the background. This would make it easier to provide a decent contrast focus style. Is there value in filling in the background? |
I understand one case for this - if we choose to drop underlines for links in some places, then contrasting the link blue from the body text black is required. Do we use green as a text colour? I can't think of a case myself. Are there any other cases where it's important to contrast the text colours from each other? |
my gut is its useful to make the focus style super garish, because unlike mouse or touch interactions it's not obvious where on screen the focus is. the current focus state is like a big neon highlighter! not sure an outline has the same impact I haven't had time to dig into specific WCAG requirements for contrast. they might have more affordance (like the contrast between normal text and links not needing to be as extreme as the contrast between text and background colour)
true, I don't think we do. is there an issue with the green being too light though? |
Closing – This work will need to be redone as it was created before the frontend restructure and moving colours to sass maps. |
GOV.UK colour palette update
Updated based on colour palette proposal from Mark Hurrell (Head of Design for GOV.UK)
$govuk-black
on$govuk-yellow
New colour palette
Visual examples in context of GOV.UK Frontend components
Preview changes
https://govuk-frontend-review-pr-611.herokuapp.com/