Fix components relying on global builds #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
reviewed
Mar 8, 2018
| @@ -26,6 +26,8 @@ Internal: | |||
| (PR [#574](https://github.com/alphagov/govuk-frontend/pull/574)) | |||
| - Ensure render function does not have undefined object | |||
| (PR [#587](https://github.com/alphagov/govuk-frontend/pull/587)) | |||
| - Fix components relying on global builds | |||
There was a problem hiding this comment.
Given footer hasn't been released yet, is this something we need to document? As the thing we're fixing was never actually released?
There was a problem hiding this comment.
Agreed, that's why this change is under 'Internal' not 'Fix'
36degrees
reviewed
Mar 8, 2018
| @@ -22,7 +22,7 @@ | |||
| "build:dist": "node bin/check-nvmrc.js && gulp build:dist --destination 'dist' && npm run test:build:dist", | |||
| "test": "standard && gulp test && npm run test:app && npm run test:components && npm run test:generate:readme", | |||
| "test:app": "jest app/__tests__/app.test.js --forceExit # express server fails to end process", | |||
| "test:components": "jest src/", | |||
| "test:components": "jest src/ && jest tasks/gulp/__tests__/check-individual-components-compile.test.js", | |||
There was a problem hiding this comment.
Should this run all tests under tasks/gulp/__tests__ rather than a specific case?
There was a problem hiding this comment.
Some of the task tests run 'after' tasks. So they're dependant on a task running.
| } | ||
|
|
||
| describe('Individual components', () => { | ||
| it('should compile individual scss files', done => { |
There was a problem hiding this comment.
Can we have an expectation in this test (expect not to throw an exception?) to make it explicit what this is testing?
Iterate through all components and build their Sass, checking for build errors.
4aaaf0d to
1f6892b
Compare
36degrees
approved these changes
Mar 8, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.