Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runner Ubuntu version to 22 #5578

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix runner Ubuntu version to 22 #5578

merged 1 commit into from
Jan 6, 2025

Conversation

domoscargin
Copy link
Contributor

We're having issues with ubuntu-latest as it's now v24. Fixing to 22 for now to allow us time to figure it out.

@domoscargin domoscargin requested a review from a team as a code owner January 6, 2025 14:41
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5578 January 6, 2025 14:42 Inactive
Copy link

github-actions bot commented Jan 6, 2025

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 118.41 KiB
dist/govuk-frontend-development.min.js 42.7 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 92.81 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 87.12 KiB
packages/govuk-frontend/dist/govuk/all.mjs 1.25 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 1.74 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 118.4 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.69 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 7.13 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 82.57 KiB 40.4 KiB
accordion.mjs 26.58 KiB 13.41 KiB
button.mjs 9.09 KiB 3.78 KiB
character-count.mjs 25.39 KiB 10.9 KiB
checkboxes.mjs 7.81 KiB 3.42 KiB
error-summary.mjs 10.99 KiB 4.54 KiB
exit-this-page.mjs 20.2 KiB 10.34 KiB
header.mjs 6.46 KiB 3.22 KiB
notification-banner.mjs 9.35 KiB 3.7 KiB
password-input.mjs 18.24 KiB 8.33 KiB
radios.mjs 6.81 KiB 2.98 KiB
service-navigation.mjs 6.44 KiB 3.26 KiB
skip-link.mjs 6.4 KiB 2.76 KiB
tabs.mjs 12.04 KiB 6.67 KiB

View stats and visualisations on the review app


Action run for 1a517ce

Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are passing again 🥳 Let's update the required checks for main in the repo settings and we're good to go.

@domoscargin domoscargin merged commit 8fbdd9d into main Jan 6, 2025
51 checks passed
@domoscargin domoscargin deleted the bk-fix-ubuntu-to-22 branch January 6, 2025 15:02
@domoscargin
Copy link
Contributor Author

Success!

We need to repeat this process for our support/4.* and feature/* branches. Likely also on alphagov/govuk-design-system and alphagov/govuk-frontend-docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants