Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scope=row attribute from non-th elements #527

Merged
merged 3 commits into from
Feb 15, 2018
Merged

Remove scope=row attribute from non-th elements #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
132af6e
Remove scope=row attribute from non-th elements
Feb 13, 2018
3b53638
Document change in CHANGELOG
Feb 14, 2018
f901d4d
Update table README
Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Fixes:
- Add `govuk-c-select--error` modifier class to the select component instead of relying on `govuk-c-input--error` (PR [#506](https://github.com/alphagov/govuk-frontend/pull/506))
- Allow error message and hint text to be passed to a select component without requiring a label parameter (PR [#506](https://github.com/alphagov/govuk-frontend/pull/506))
- Define size of inputs etc in `px` rather than `em`. (PR [#491](https://github.com/alphagov/govuk-frontend/pull/491))
- Remove scope=row attribute from non-th elements (PR [527](https://github.com/alphagov/govuk-frontend/pull/527))

Internal:

Expand Down
12 changes: 6 additions & 6 deletions src/components/table/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Find out when to use the Table component in your service in the [GOV.UK Design S

<tr class="govuk-c-table__row">

<td class="govuk-c-table__cell" scope="row">January</td>
<td class="govuk-c-table__cell">January</td>

<td class="govuk-c-table__cell govuk-c-table__cell--numeric">£85</td>

Expand All @@ -32,7 +32,7 @@ Find out when to use the Table component in your service in the [GOV.UK Design S

<tr class="govuk-c-table__row">

<td class="govuk-c-table__cell" scope="row">February</td>
<td class="govuk-c-table__cell">February</td>

<td class="govuk-c-table__cell govuk-c-table__cell--numeric">£75</td>

Expand All @@ -42,7 +42,7 @@ Find out when to use the Table component in your service in the [GOV.UK Design S

<tr class="govuk-c-table__row">

<td class="govuk-c-table__cell" scope="row">March</td>
<td class="govuk-c-table__cell">March</td>

<td class="govuk-c-table__cell govuk-c-table__cell--numeric">£165</td>

Expand Down Expand Up @@ -123,7 +123,7 @@ Find out when to use the Table component in your service in the [GOV.UK Design S

<tr class="govuk-c-table__row">

<td class="govuk-c-table__cell" scope="row">January</td>
<td class="govuk-c-table__cell">January</td>

<td class="govuk-c-table__cell govuk-c-table__cell--numeric">£85</td>

Expand All @@ -133,7 +133,7 @@ Find out when to use the Table component in your service in the [GOV.UK Design S

<tr class="govuk-c-table__row">

<td class="govuk-c-table__cell" scope="row">February</td>
<td class="govuk-c-table__cell">February</td>

<td class="govuk-c-table__cell govuk-c-table__cell--numeric">£75</td>

Expand All @@ -143,7 +143,7 @@ Find out when to use the Table component in your service in the [GOV.UK Design S

<tr class="govuk-c-table__row">

<td class="govuk-c-table__cell" scope="row">March</td>
<td class="govuk-c-table__cell">March</td>

<td class="govuk-c-table__cell govuk-c-table__cell--numeric">£165</td>

Expand Down
2 changes: 1 addition & 1 deletion src/components/table/template.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<td class="govuk-c-table__cell
{%- if cell.format %} govuk-c-table__cell--{{ cell.format }}{% endif %}"
{%- if cell.colspan %} colspan="{{ cell.colspan }}"{% endif %}
{%- if cell.rowspan %} rowspan="{{ cell.rowspan }}"{% endif %} scope="row">{{ cell.html | safe if cell.html else cell.text }}</td>
{%- if cell.rowspan %} rowspan="{{ cell.rowspan }}"{% endif %}>{{ cell.html | safe if cell.html else cell.text }}</td>
{% else %}
<td class="govuk-c-table__cell {% if cell.format %}govuk-c-table__cell--{{ cell.format }}{% endif %}"
{%- if cell.colspan %} colspan="{{ cell.colspan }}"{% endif %}
Expand Down