Run axe in jest, with failing builds #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36403bc to
229ce1c
Compare
068180a to
8eaaf4a
Compare
8eaaf4a to
9b2ae23
Compare
9b2ae23 to
99a865b
Compare
99a865b to
e7af611
Compare
NickColley
commented
Feb 13, 2018
src/components/table/README.md
Outdated
| @@ -22,7 +22,7 @@ More information about when to use table can be found on [GOV.UK Design System]( | |||
|
|
|||
| <tr class="govuk-c-table__row"> | |||
|
|
|||
| <td class="govuk-c-table__cell" scope="row">January</td> | |||
| <td class="govuk-c-table__cell">January</td> | |||
There was a problem hiding this comment.
Can I get a review on this change? I'm not super savvy on table semantics.
|
Talked through this PR with @igloosi we agreed we should remove the table issue from this PR and raise an issue to fix it. |
|
nicely explained by @NickColley how it works. would love to have @alex-ju @hannalaakso and @36degrees to have a look as well |
e7af611 to
6e782cd
Compare
alex-ju
reviewed
Feb 14, 2018
package.json
Outdated
| @@ -54,6 +53,7 @@ | |||
| "gulp-to-markdown": "^1.0.0", | |||
| "gulp-uglify": "^3.0.0", | |||
| "jest": "^22.1.4", | |||
| "jest-axe": "^2.1.0", | |||
Includes jest-axe, which allows us to run axe-core directly within our unit tests.
6e782cd to
e667d03
Compare
hannalaakso
approved these changes
Feb 15, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/nickcolley/jest-axe for source code for the module.
Timings, before:
Timings, after:
This work is based on the work on https://github.com/alphagov/govuk_publishing_components 's interaction with aXe