Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for date input macro #495

Merged
merged 3 commits into from
Feb 2, 2018
Merged

Add tests for date input macro #495

merged 3 commits into from
Feb 2, 2018

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Feb 2, 2018

This PR:

  • Adds tests to input component to ensure the markup is rendered correctly when providing arguments to the macro;
  • Updates table of argument by adding missing name attribute, documenting id and ordering them;
  • Updates CHANGELOG.MD.

Trello Card

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-495 February 2, 2018 16:22 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-495 February 2, 2018 16:24 Inactive
@NickColley
Copy link
Contributor

NickColley commented Feb 2, 2018 •
edited
Loading

Ship it

@alex-ju alex-ju force-pushed the add-tests-for-date-input-macro branch from ad4672e to e1b7387 Compare February 2, 2018 16:39
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-495 February 2, 2018 16:40 Inactive
@alex-ju alex-ju force-pushed the add-tests-for-date-input-macro branch from e1b7387 to 828a79d Compare February 2, 2018 16:58
@alex-ju alex-ju merged commit 3e1391a into master Feb 2, 2018
@alex-ju alex-ju deleted the add-tests-for-date-input-macro branch February 2, 2018 17:02
@alex-ju alex-ju mentioned this pull request Feb 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickColley NickColley NickColley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-ju @NickColley @govuk-design-system-ci