Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cookie-banner and Previous-next components #488

Merged
merged 5 commits into from
Feb 2, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Jan 31, 2018

Current set components and patterns should only be what already exists in Elements, SM and prototype kit examples.

Cookie banner is provided by GOV.UK Template. The previous next component is a GOV.UK Publishing component.

For now we're temporarily removing these two components.

Trello: https://trello.com/c/soy1eGtS/441-1-remove-cookie-banner-and-previous-next-from-frontend-temporary-change

Removed from packages as well, otherwise test on build:packages fails.

Jani Kraner added 4 commits January 31, 2018 14:53
Due to missing guidance in the Design System, as this is a GOV.UK
Publishing component.
Lacking guidance in the Design System as this is a GOV.UK Template
component.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-488 January 31, 2018 15:05 Inactive
@kr8n3r kr8n3r changed the title Remove Cookie-banner and Previous-Next components Remove Cookie-banner and Previous-next components Jan 31, 2018
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@kr8n3r kr8n3r merged commit d6c2dab into master Feb 2, 2018
@kr8n3r kr8n3r deleted the temp-removal-of-components branch February 2, 2018 14:12
alex-ju added a commit that referenced this pull request Feb 13, 2018
@alex-ju alex-ju mentioned this pull request Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants