Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog entry for #4562 #4624

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Add changelog entry for #4562 #4624

merged 1 commit into from
Jan 10, 2024

Conversation

owenatgov
Copy link
Contributor

Adds a changelog entry for #4562

@owenatgov owenatgov requested a review from a team January 9, 2024 15:55
Copy link

github-actions bot commented Jan 9, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 112.45 KiB
dist/govuk-frontend-development.min.js 38.58 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 78.74 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 73.99 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.86 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 112.44 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 38.57 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.38 KiB

Modules

File Size
all.mjs 70.32 KiB
components/accordion/accordion.mjs 21.67 KiB
components/button/button.mjs 4.7 KiB
components/character-count/character-count.mjs 21.24 KiB
components/checkboxes/checkboxes.mjs 5.83 KiB
components/error-summary/error-summary.mjs 6.57 KiB
components/exit-this-page/exit-this-page.mjs 16.08 KiB
components/header/header.mjs 4.46 KiB
components/notification-banner/notification-banner.mjs 4.93 KiB
components/radios/radios.mjs 4.83 KiB
components/skip-link/skip-link.mjs 4.39 KiB
components/tabs/tabs.mjs 10.16 KiB

View stats and visualisations on the review app


Action run for 689d837

@owenatgov owenatgov self-assigned this Jan 9, 2024
@colinrotherham
Copy link
Contributor

Thanks @owenatgov, we didn't document --govuk-frontend-version either. Do we need to?

For this entry though, do we need to explain that custom Sass $govuk-breakpoints edits will be reflected?

@owenatgov
Copy link
Contributor Author

@colinrotherham On the premise of making this a feature changelog, it sorta depends what we want. Are we bothered about users not knowing that we have CSS custom properties? Personally I'm not gonna kick off if we convert this to just a fix and call it a day.

@colinrotherham
Copy link
Contributor

colinrotherham commented Jan 9, 2024

@owenatgov Yeah, it's a fix but probably still needs an entry 😆

E.g. Users that override Sass $govuk-breakpoints will now see Tabs and Header components use them

But perhaps keep the CSS custom properties for internal/private use for now?

@owenatgov
Copy link
Contributor Author

@colinrotherham I'm fine with keeping the custom props private. Shall we just make it a fix for ease? Just throw in the title of the PR and add it to the fixes list?

@owenatgov owenatgov force-pushed the matchmedia-changelog branch from 56113ae to 689d837 Compare January 10, 2024 11:23
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4624 January 10, 2024 11:24 Inactive
@owenatgov owenatgov merged commit 80ba89e into main Jan 10, 2024
44 checks passed
@owenatgov owenatgov deleted the matchmedia-changelog branch January 10, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants