-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog entry for #4562 #4624
Conversation
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 689d837 |
Thanks @owenatgov, we didn't document For this entry though, do we need to explain that custom Sass |
@colinrotherham On the premise of making this a feature changelog, it sorta depends what we want. Are we bothered about users not knowing that we have CSS custom properties? Personally I'm not gonna kick off if we convert this to just a fix and call it a day. |
@owenatgov Yeah, it's a fix but probably still needs an entry 😆 E.g. Users that override Sass But perhaps keep the CSS custom properties for internal/private use for now? |
@colinrotherham I'm fine with keeping the custom props private. Shall we just make it a fix for ease? Just throw in the title of the PR and add it to the fixes list? |
56113ae
to
689d837
Compare
Adds a changelog entry for #4562