Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gulp to copy files instead of cpy #4560

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Use Gulp to copy files instead of cpy #4560

merged 4 commits into from
Dec 14, 2023

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Dec 12, 2023

Adding a dash of Gulp back again 😶

Closes #4439 by replacing our files.copy() task with gulp.src() + gulp.dest()

Removing the cpy package

This lets us remove the cpy package added in 8edda31 due to the maintainer stating:

IMPORTANT: This package has a lot of problems and I unfortunately don't have time to fix them. I would recommend against using this package until these problems are resolved. Help welcome (see the issue tracker) 🙏

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4560 December 12, 2023 12:16 Inactive
Copy link

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 113.72 KiB
dist/govuk-frontend-development.min.js 38.54 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 78.3 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 73.58 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.86 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.7 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 38.53 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.38 KiB

Modules

File Size
all.mjs 69.9 KiB
components/accordion/accordion.mjs 21.67 KiB
components/button/button.mjs 4.7 KiB
components/character-count/character-count.mjs 21.24 KiB
components/checkboxes/checkboxes.mjs 5.83 KiB
components/error-summary/error-summary.mjs 6.09 KiB
components/exit-this-page/exit-this-page.mjs 16.08 KiB
components/header/header.mjs 3.9 KiB
components/notification-banner/notification-banner.mjs 4.54 KiB
components/radios/radios.mjs 4.83 KiB
components/skip-link/skip-link.mjs 4.3 KiB
components/tabs/tabs.mjs 9.66 KiB

View stats and visualisations on the review app


Action run for 50f0515

Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for sorting this out 🙌🏻

@colinrotherham colinrotherham merged commit 049d732 into main Dec 14, 2023
@colinrotherham colinrotherham deleted the gulp-copy branch December 14, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace dependency: cpy
3 participants