Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional .gitignore files to package:clean task #4375

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Oct 24, 2023

Updates the npm run package:clean task to also remove:

  1. Built config file govuk-prototype-kit.config.json
  2. Built cache file tsconfig.build.tsbuildinfo (watch task lint:types output, optional)

Verify package tests

These files are part of the tests to verify npm run build:package and should be "cleaned" before run

// Compare array of actual output files
expect(listingDist).toEqual(listingExpected)
// Check top level package contents
expect(listingPackage).toEqual([

@colinrotherham colinrotherham added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) assurance labels Oct 24, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4375 October 24, 2023 10:30 Inactive
@github-actions
Copy link

📋 Stats

File sizes

File Size
dist/govuk-frontend-4.7.0.min.css 120.66 KiB
dist/govuk-frontend-4.7.0.min.js 51.56 KiB
dist/govuk-frontend-ie8-4.7.0.min.css 81.59 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 76.76 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 72.07 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.8 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.99 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 37.83 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.3 KiB

Modules

File Size
all.mjs 68.4 KiB
components/accordion/accordion.mjs 21.05 KiB
components/button/button.mjs 4.18 KiB
components/character-count/character-count.mjs 20.49 KiB
components/checkboxes/checkboxes.mjs 5.31 KiB
components/error-summary/error-summary.mjs 5.49 KiB
components/exit-this-page/exit-this-page.mjs 15.49 KiB
components/header/header.mjs 3.39 KiB
components/notification-banner/notification-banner.mjs 4.02 KiB
components/radios/radios.mjs 4.31 KiB
components/skip-link/skip-link.mjs 3.3 KiB
components/tabs/tabs.mjs 9.07 KiB

View stats and visualisations on the review app


Action run for 4256c2b

@colinrotherham colinrotherham merged commit d65549d into main Oct 24, 2023
45 checks passed
@colinrotherham colinrotherham deleted the package-clean branch October 24, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assurance 🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
Development

Successfully merging this pull request may close these issues.

3 participants