Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the test group with 1 update #4335

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 16, 2023

Bumps the test group with 1 update: @axe-core/puppeteer.

Changelog

Sourced from @​axe-core/puppeteer's changelog.

Change Log

All notable changes to this project will be documented in this file. See Conventional Commits for commit guidelines.

4.8.0 (2023-09-28)

Bug Fixes

  • cli: better error message for ChromeDriver version mismatch (#680) (10cf350), closes #679
  • cli: improve error message on script timeout (#681) (b407c6c)
  • cli: respect --exit regardless of other flags (#750) (bfa2328)
  • pin axe-core version to accept patch updates only (#838) (2456ed6)
  • skip unloaded iframes for all apis (#752) (0b15629)

Features

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Oct 16, 2023
@dependabot dependabot bot requested a review from a team October 16, 2023 09:43
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4335 October 16, 2023 09:43 Inactive
@github-actions
Copy link

github-actions bot commented Oct 16, 2023

📋 Stats

File sizes

File Size
dist/govuk-frontend-4.7.0.min.css 120.66 KiB
dist/govuk-frontend-4.7.0.min.js 51.56 KiB
dist/govuk-frontend-ie8-4.7.0.min.css 81.59 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 75.78 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 71.15 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.84 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.99 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 36.87 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.3 KiB

Modules

File Size
all.mjs 67.48 KiB
components/accordion/accordion.mjs 20.61 KiB
components/button/button.mjs 4.55 KiB
components/character-count/character-count.mjs 20.73 KiB
components/checkboxes/checkboxes.mjs 5.69 KiB
components/error-summary/error-summary.mjs 5.85 KiB
components/exit-this-page/exit-this-page.mjs 15.81 KiB
components/header/header.mjs 3.84 KiB
components/notification-banner/notification-banner.mjs 4.39 KiB
components/radios/radios.mjs 4.68 KiB
components/skip-link/skip-link.mjs 3.73 KiB
components/tabs/tabs.mjs 9.41 KiB

View stats and visualisations on the review app


Action run for b4f1d84

@owenatgov
Copy link
Contributor

Accessibility tests are failing here because on accordions, we use aria-labelledby on the div containing the content (govuk-accordion__section-content) which according to axe, isn't allowed if the div doesn't have a valid role.

@colinrotherham
Copy link
Contributor

Thanks @owenatgov @domoscargin

I've updated the GitHub issue #2472 (comment)

Will wait for @dav-idc to confirm, hopefully adding a fix is quicker than a new rule to temporarily ignore it

Bumps the test group with 1 update: [@axe-core/puppeteer](https://github.com/dequelabs/axe-core-npm).

- [Release notes](https://github.com/dequelabs/axe-core-npm/releases)
- [Changelog](https://github.com/dequelabs/axe-core-npm/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/dequelabs/axe-core-npm/commits)

---
updated-dependencies:
- dependency-name: "@axe-core/puppeteer"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: test
...

Signed-off-by: dependabot[bot] <support@github.com>
Axe v4.8 violation has now changed to:

"Elements must only use permitted ARIA attributes (aria-prohibited-attr)"

Fix all of the following:
  aria-labelledby attribute cannot be used on a div with no valid role attribute.
Axe v4.8 now allows checkbox input `aria-expanded` from ARIA 1.2

dequelabs/axe-core#3343 (comment)
@colinrotherham colinrotherham force-pushed the dependabot/npm_and_yarn/test-4b275cfb80 branch from a863676 to b4f1d84 Compare October 17, 2023 12:35
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4335 October 17, 2023 12:35 Inactive
@colinrotherham
Copy link
Contributor

colinrotherham commented Oct 17, 2023

I've pushed a few updates this PR needed:

  1. Remove the Checkboxes rule aria-allowed-attr since dequelabs/axe-core/pull/3343

  2. Rename the Accordion rule aria-allowed-attr to aria-prohibited-attr

    "Elements must only use permitted ARIA attributes (aria-prohibited-attr)"

    Fix all of the following:
    aria-labelledby attribute cannot be used on a div with no valid role attribute.

  3. Uninstalled and reinstalled to ensure axe-core@4.8.2 is hoisted to project root

    npm uninstall jest-axe @axe-core/puppeteer --workspace shared/helpers
    npm install --save-dev jest-axe @axe-core/puppeteer --workspace shared/helpers

@colinrotherham colinrotherham merged commit 94e66e6 into main Oct 17, 2023
@colinrotherham colinrotherham deleted the dependabot/npm_and_yarn/test-4b275cfb80 branch October 17, 2023 12:59
owenatgov pushed a commit that referenced this pull request Oct 18, 2023
…b275cfb80

Bump the test group with 1 update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility dependencies Pull requests that update a dependency file javascript
Projects
Development

Successfully merging this pull request may close these issues.

4 participants