Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Contributing and Changelog #433

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Update Contributing and Changelog #433

merged 1 commit into from
Jan 18, 2018

Conversation

hannalaakso
Copy link
Member

@hannalaakso hannalaakso commented Jan 17, 2018 •
edited
Loading

This PR updates CONTRIBUTING and CHANGELOG with:

  • Information on how to update CHANGELOG.
  • New contribution category Internal (as suggested by @NickColley).
  • Tidy up of Versioning section in CONTRIBUTING to reflect the latest FE.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-433 January 17, 2018 18:00 Inactive
NickColley
NickColley approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good additions thanks Hanna 👍

@hannalaakso hannalaakso force-pushed the update-contributing-with-changelog branch from dfd0c21 to 62890d3 Compare January 18, 2018 09:39
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-433 January 18, 2018 09:39 Inactive
@hannalaakso hannalaakso force-pushed the update-contributing-with-changelog branch from 62890d3 to 2025d48 Compare January 18, 2018 09:43
@hannalaakso hannalaakso merged commit 70f800a into master Jan 18, 2018
@hannalaakso hannalaakso deleted the update-contributing-with-changelog branch January 18, 2018 09:49
This was referenced Jan 18, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickColley NickColley NickColley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannalaakso @NickColley @govuk-design-system-ci