-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ES2015+ supported features #4286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 2, 2023 10:07
Inactive
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 47f697d |
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 2, 2023 10:49
eac8c3b
to
261e9cd
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 2, 2023 10:49
Inactive
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 2, 2023 11:03
261e9cd
to
5793396
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 2, 2023 11:03
Inactive
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 10, 2023 16:07
5793396
to
0c8dfe3
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 10, 2023 16:07
Inactive
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 10, 2023 16:09
0c8dfe3
to
0ce23c1
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 10, 2023 16:09
Inactive
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 12, 2023 12:39
0ce23c1
to
04a013a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 12, 2023 12:40
Inactive
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 17, 2023 11:01
04a013a
to
405ae2d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 17, 2023 11:01
Inactive
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 17, 2023 11:33
405ae2d
to
ca819dd
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 17, 2023 11:33
Inactive
colinrotherham
force-pushed
the
null-checks
branch
from
October 18, 2023 14:35
546865c
to
86076b1
Compare
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 18, 2023 14:38
ca819dd
to
abe8748
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 18, 2023 14:38
Inactive
colinrotherham
force-pushed
the
null-checks
branch
from
October 19, 2023 11:09
86076b1
to
c2d54b5
Compare
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 19, 2023 11:09
abe8748
to
1b80182
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 19, 2023 11:09
Inactive
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 19, 2023 11:20
1b80182
to
79651f2
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 19, 2023 11:20
Inactive
colinrotherham
changed the title
[SPIKE] Try ES2015+ transpiled or supported features
Allow ES2015+ supported features
Oct 23, 2023
colinrotherham
force-pushed
the
null-checks
branch
2 times, most recently
from
October 23, 2023 11:21
79b4285
to
4fb611f
Compare
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 23, 2023 11:22
79651f2
to
53f8d08
Compare
colinrotherham
force-pushed
the
syntax-enabled
branch
from
October 31, 2023 14:12
bdf0658
to
e66c296
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
October 31, 2023 14:13
Inactive
colinrotherham
added a commit
that referenced
this pull request
Nov 8, 2023
We have another PR open to discuss these features: #4286 Some ES2015+ features already have browser support or are enabled by Babel transforms
colinrotherham
force-pushed
the
syntax-enabled
branch
from
November 8, 2023 12:14
e66c296
to
98a70b7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
November 8, 2023 12:15
Inactive
colinrotherham
force-pushed
the
syntax-enabled
branch
from
November 8, 2023 12:28
98a70b7
to
19f5bb8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
November 8, 2023 12:28
Inactive
colinrotherham
force-pushed
the
syntax-enabled
branch
from
November 8, 2023 12:32
19f5bb8
to
1cd7f19
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
November 8, 2023 12:33
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
November 8, 2023 12:37
Inactive
colinrotherham
force-pushed
the
syntax-enabled
branch
from
November 8, 2023 12:42
4dff09c
to
03210ab
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
November 8, 2023 12:43
Inactive
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
November 8, 2023 12:49
Inactive
querkmachine
pushed a commit
that referenced
this pull request
Nov 13, 2023
We have another PR open to discuss these features: #4286 Some ES2015+ features already have browser support or are enabled by Babel transforms
ES modules include ES2016 '[].includes()' coverage: https://browsersl.ist/#q=supports+es6-module+and+not+supports+array-includes
Babel transpiles ES2020 `?.` optional chaining for our Browserslist supported browsers
Babel transpiles ES2020 `??` nullish coalescing for our Browserslist supported browsers
colinrotherham
force-pushed
the
syntax-enabled
branch
from
November 20, 2023 10:24
22250b4
to
47f697d
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4286
November 20, 2023 10:25
Inactive
romaricpascal
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely handy features to be able to use 😊
owenatgov
pushed a commit
that referenced
this pull request
Jan 11, 2024
We have another PR open to discuss these features: #4286 Some ES2015+ features already have browser support or are enabled by Babel transforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls together a few ES2015+ code changes with their supporting ESLint config
These were recommendations from the ESLint stylistic typed linting plugin in #4106
Already supported by ES modules
ES2015Done in #4322Array.from()
''.includes()
[].includes()
ES2017Done in #4322Object.entries()
Total bundle size
all.mjs
69.3 KiB68.66 KiBBabel transforms without polyfills
?.
optional chaining (+ 0.09 KiB)??
nullish coalescing (+ 0.55 KiB)Total bundle size
all.mjs
68.66 KiB69.3 KiBTransform examples
Note the following size increases using
!=
versus!==
to check for nullish rather than falsy valuesBefore
After