Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial i18n lookup function #2814

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Add initial i18n lookup function #2814

merged 1 commit into from
Aug 30, 2022

Conversation

querkmachine
Copy link
Member

@querkmachine querkmachine commented Aug 26, 2022

Adds the most basic version of the i18n function used to lookup and return translation strings, and implements it for the Accordion component's default strings.

This doesn't touch the Character Count component, as this requires placeholder and pluralisation support, which is being added later.

Will close #2801 upon completion.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2814 August 26, 2022 15:58 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2814 August 30, 2022 09:54 Inactive
@querkmachine querkmachine marked this pull request as ready for review August 30, 2022 09:58
@querkmachine querkmachine requested a review from a team August 30, 2022 09:58
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2814 August 30, 2022 09:59 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2814 August 30, 2022 10:05 Inactive
Copy link
Contributor

@vanitabarrett vanitabarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 👏

@querkmachine querkmachine merged commit e7a8722 into main Aug 30, 2022
@querkmachine querkmachine deleted the kg-i18n-support branch August 30, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add internationalisation logic to lookup translation from key
3 participants