Fix select component renders with grey background in Firefox and Safari #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef41172 to
3861598
Compare
3861598 to
f79fbc6
Compare
f79fbc6 to
35b1a37
Compare
36degrees
approved these changes
Feb 1, 2022
added 2 commits
February 1, 2022 13:59
Sets the background and foreground colours (`background-color` and `color`) on the select component to fix #2435 We're setting both the background and foreground so we don't fail WCAG by specifying background colours without foreground colour (https://www.w3.org/TR/WCAG20-TECHS/F24.html): Unless an author specifies both foreground and background colors, then they (the author) can no longer guarantee that the user will get a contrast that meets the contrast requirements.
35b1a37 to
506b858
Compare
This was referenced Feb 1, 2022
This was referenced Feb 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2435
What
Sets background colour and text colour on the select component so that we have more control over the background and foreground colour and don't get influenced by browser defaults which sometimes default to a grey background.
Why
We have had two separate reports from users of the select component appearing with a grey background in Firefox and iOS Safari. In iOS Safari, the text within the select also appears as blue - the blue text on grey background does not meet colour contrast (ratio 2.19:1). We should probably raise a WebKit bug for this too, but alongside the issue in Firefox it probably also makes sense for us to look at getting more control over our component styling too.
Screenshots (default component)
Chrome:
iOS:
Firefox:
IE11:
Screenshots (colours changed)
Windows High Contrast, Edge:
Windows High Contrast, Chrome:
Windows High Contrast, Firefox:
Windows High Contrast, IE11:
Firefox (changed colours):
