Add support for footer sections that span multiple columns #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5eb9bd5 to
79a21c3
Compare
d4b82f7 to
642be02
Compare
14 tasks
039049f to
6d0f09d
Compare
Allow having a footer section that spans multiple columns but does not have multiple columns of list items. Useful if you have multiple rows of sections and want to align a section with only a few items with a section with many items (for instance the current GOV.UK footer layout).
This commit takes the example screenshot from this issue #1726 - where it's reported that it's not possible to build the layout given the alignment issues - and adds a version of the footer to the full page example campaign page in the review app so we have an example of this layout to test against.
6d0f09d to
c9bfb6d
Compare
When the footer example has 'GOV.UK' in the name, it gets flagged by Chrome as a possible spam/phishing site which means you can't open that example in a new window. This commit works around that issue by renaming the example - it seems to be the word "GOV.UK" which triggers it
85b5aa4 to
7c4ea3c
Compare
1 task
45cbcd6 to
9159153
Compare
9159153 to
ea725c5
Compare
ea725c5 to
c379542
Compare
|
Superseded by #2462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #1726
Note: this PR is based off the changes made in #2428
Allow having a footer section that spans multiple columns but does not have multiple columns of list items. Useful if you have multiple rows of sections and want to align a section with only a few items with a section with many items (for instance the current GOV.UK footer layout).
Browsers to test in:
https://govuk-frontend-pr-2446.herokuapp.com/full-page-examples/campaign-page
https://govuk-frontend-pr-2446.herokuapp.com/components/footer/Full-GDS-example/preview