Set -webkit-appearance: button on file upload so text is aligned in Safari
#2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd3b376 to
08566aa
Compare
-webkit-appearance: button on file upload so text is aligned
-webkit-appearance: button on file upload so text is aligned-webkit-appearance: button on file upload so text is aligned in Safari
36degrees
approved these changes
Apr 26, 2021
added 2 commits
April 26, 2021 10:42
The default file upload button in Safari does not support setting a custom font-size, which pushes the text out of alignment on desktop. Set `-webkit-appearance` to `button` to drop out of the native appearance so the font-size is set to 19px https://bugs.webkit.org/show_bug.cgi?id=224746
c730d9f to
6997d57
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2194
What
In Safari, the text of the file upload component was mis-aligned with the upload button on desktop, due to the font-size not being properly applied to the button. Safari say:
Setting -webkit-appearance: none
Setting
-webkit-appearance: nonefixes the alignment issue as the font-size can now be set correctly. However, setting appearance to none suggests the element has no "special" appearance - "No special styling is applied. This is the default." (https://developer.mozilla.org/en-US/docs/Web/CSS/appearance).Setting -webkit-appearance: button
Setting appearance to
buttonmeans that "the element is drawn like a button", which is more appropriate for our use case.However, the button goes grey with white text when pressed, which fails colour contrast recommendations (2.09:1 instead of 4.5:1). So we need to also set the text colour for the button.
Cross-browser testing
Because we're nesting
-webkit-appearancewithin a::-webkit-file-upload-buttonselector, this doesn't have any effect in the majority of browsers. The only change I observed was in Safari (Mac). Full selection of screenshots here