Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release process to guide team practice #2174

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

EoinShaughnessy
Copy link
Contributor

@EoinShaughnessy EoinShaughnessy commented Mar 30, 2021

Addresses #2175 (Map release process and identify pain points).

We recently had a retro to identify pain points in our release process.

This pull request contains revised steps, based on team feedback, to the doc for our release process. For example, that no major changes should go into a release after an agreed cutoff-point.

Hopefully these revisions will make our future releases run more smoothly.

@EoinShaughnessy EoinShaughnessy added documentation User requests new documentation or improvements to existing documentation 🕔 days labels Mar 30, 2021
@EoinShaughnessy EoinShaughnessy self-assigned this Mar 30, 2021
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2174 March 30, 2021 09:26 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2174 March 30, 2021 09:33 Inactive
@EoinShaughnessy EoinShaughnessy linked an issue Mar 30, 2021 that may be closed by this pull request
5 tasks
@EoinShaughnessy
Copy link
Contributor Author

Do we need to change master to main in this content? Or can that wait till we've completed the branch-renaming work?

@vanitabarrett
Copy link
Contributor

@EoinShaughnessy I think we can do that separately - it might take us a while to do the rename and we probably don't want to update the docs until it's done, so I wouldn't want us to block this PR 🙂

Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EoinShaughnessy 🎉 I think these changes will really help us to streamline the release process. Noticed a couple of small things that just need tidying up.

docs/releasing/publishing.md Outdated Show resolved Hide resolved
docs/releasing/publishing.md Outdated Show resolved Hide resolved
docs/releasing/publishing.md Outdated Show resolved Hide resolved
docs/releasing/publishing.md Outdated Show resolved Hide resolved
docs/releasing/publishing.md Outdated Show resolved Hide resolved
docs/releasing/publishing.md Outdated Show resolved Hide resolved
docs/releasing/publishing.md Outdated Show resolved Hide resolved
docs/releasing/publishing.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2174 April 8, 2021 12:26 Inactive
@EoinShaughnessy
Copy link
Contributor Author

EoinShaughnessy commented Apr 8, 2021

@hannalaakso Thanks for the excellent review! I think I've actioned your feedback now. If things look ok, I'll add in the final commits and then get to squashing.

Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all my comments @EoinShaughnessy, this looks good to me 🙏 I've given it an approval but squashing the commits before it's merged sounds great.

docs/releasing/publishing.md Outdated Show resolved Hide resolved
docs/releasing/publishing.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2174 April 9, 2021 07:49 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2174 April 9, 2021 07:49 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2174 April 9, 2021 07:50 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2174 April 9, 2021 07:51 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2174 April 9, 2021 07:51 Inactive
@EoinShaughnessy EoinShaughnessy force-pushed the update-release-process branch from 0f5b672 to 7d9a3c4 Compare April 9, 2021 07:59
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2174 April 9, 2021 07:59 Inactive
@EoinShaughnessy EoinShaughnessy merged commit 3480696 into master Apr 9, 2021
@EoinShaughnessy EoinShaughnessy deleted the update-release-process branch April 9, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation User requests new documentation or improvements to existing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map release process and identify pain points
4 participants