-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required fields to examples #1990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The label component also seems to mark the for
param as required, but most of the examples do not include it (and the template handles it being omitted) so possibly it shouldn't be marked as required?
@36degrees Thanks for the review - I think I've addressed them all now in the last few commits. I've marked the label for attribute as not required (49c5308) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me. I haven't manually verified every single example - but until we've got a way to programatically validate all the examples I think we have to treat this as a 'best effort' exercise anyway.
Closes #1965
What
Why
In a previous PR we reviewed the
required
attributes on all our component options to double check that they're correct (#1979). Following on from that work, we want to make sure the examples in the YAML files (used for tests and to generatemacro-options.json
andfixtures.json
) properly reflect the required attributes.