Make it possible to exclude link from header navigation item #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
reviewed
Aug 20, 2020
Currently if you don't pass a `href` the navigation item link won't render when using the header macro. This PR changes the navigation link to render without the link wrapper if `item.text` or `item.html` is set but `href` isn't. We would expect this to be mainly useful for rendering a form for instance for adding a log out button. The team will need to style any enclosed form elements or buttons correctly.
4a4d934 to
1956be3
Compare
36degrees
approved these changes
Sep 3, 2020
1956be3 to
f3d5aaf
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
item.hrefbeing setitem.textanditem.htmlcan render a navigation item without a linkWe would expect this to be mainly useful for rendering a form for instance for adding a log out button. The team would need to manually style any enclosed form elements or buttons.
I considered not allowing this behaviour for
item.textas it seems unlikely you'd want to omit the link when passing through simple text content. However I decided against in order to keep the API simpler, the fork in logic would require documentation undernavigation.item.hrefeg.But happy to re-consider this.
Fixes #1573