Fix tabs component throwing JavaScript errors in Internet Explorer 8 #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
578331a to
9ac8d4c
Compare
hannalaakso
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
Thanks @NickColley . This matches previousElementSibling and nextElementSibling in MDN web docs.
In Internet Explorer 8 errors are thrown when checking the nodeType as nextSibiling is undefined, so to fix this issue we should first check if there is a next sibiling which matches the conditional in the while loop. Fixes #1490
9ac8d4c to
ad409d4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Internet Explorer 8 errors are thrown when checking the nodeType as nextSibling is undefined, so to fix this issue I've reverted to a previous version of the code.
We previously updated this pull request to mirror a pull request in the polyfill-service repository for consistency here: 4997c72
Interestingly these polyfills are not in the new library so I cannot upstream this fix but I've raised an issue to see why they did not port it to the new library: https://github.com/Financial-Times/polyfill-library/issues/338
Fixes #1490