Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full page example that demonstrates small form controls #1300

Merged
merged 4 commits into from
Apr 30, 2019

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented Apr 29, 2019

Superseeds #1212

This example demonstrates the small checkboxes and radios, it uses a single data set that is then shuffled depending on what inputs you use to simulate a real interaction.

Live demonstration: https://govuk-frontend-review-pr-1300.herokuapp.com/full-page-examples/news-and-communications

This will allow us to shuffle a data set in a deterministic way
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1300 April 29, 2019 14:37 Inactive
hannalaakso and others added 2 commits April 29, 2019 15:41
Since we're shuffling one data set we don't need the different
variations for each result

Co-authored-by: Nick Colley <nick.colley@digital.cabinet-office.gov.uk>
Shuffle results order based on filters

Add small form inputs to view.

Remove error validation from filters as we cover this with
another example.

Co-authored-by: Nick Colley <nick.colley@digital.cabinet-office.gov.uk>
@NickColley NickColley force-pushed the small-form-controls-for-full-page-template-2 branch from 6c8f762 to 2ff2158 Compare April 29, 2019 14:42
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1300 April 29, 2019 14:42 Inactive
@NickColley NickColley changed the title Small form controls for full page template Add full page example that demonstrates small form controls Apr 29, 2019
Copy link
Contributor

@aliuk2012 aliuk2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We are going to have to rebase v3 so that we have this example in v3.

Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick 👍

@NickColley NickColley merged commit a686b9b into master Apr 30, 2019
@NickColley NickColley deleted the small-form-controls-for-full-page-template-2 branch April 30, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants