Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add views that use govuk-frontend and legacy elements/template #1282

Merged
merged 5 commits into from
Apr 30, 2019
Merged

Add views that use govuk-frontend and legacy elements/template #1282

merged 5 commits into from
Apr 30, 2019

Conversation

hannalaakso
Copy link
Member

@hannalaakso hannalaakso commented Apr 23, 2019 •
edited
Loading

This PR

  • adds start page view which extends govuk_template
  • adds applicant details view which extends govuk_template
  • exposes node_modules to review app for the purposes of extending govuk_template in app/views
  • fixes template assets path
  • sets assets path for legacy scss

Part of #1262

@hannalaakso
Set assets path for legacy scss
40505b6
@hannalaakso
Fix template assets path
e1b1837 
This should be looking at /assets so that it can be used for routing
/images as well
@hannalaakso
Expose node_modules to review app
482ba55 
In order to extend govuk_template in app/views
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1282 April 23, 2019 16:13 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1282 April 24, 2019 11:37 Inactive
@hannalaakso
Add start page view which extends govuk_template
44c43d1 
Include govuk-frontend, elements and toolkit styles.

Use legacy heading, paragraph, button and list, and govuk-frontend
breadcrumbs and tabs.
@hannalaakso
Add applicant details view which extends govuk_template
c33d7a0 
Include govuk-frontend, elements and toolkit styles.

Use legacy error summary, error message and text input, and
govuk-frontend backlink, date input, button and panel.
@hannalaakso hannalaakso force-pushed the create-legacy-template-view branch from 8a312df to c33d7a0 Compare April 24, 2019 14:48
@hannalaakso hannalaakso marked this pull request as ready for review April 24, 2019 14:54
@36degrees 36degrees added this to the v3.0.0 milestone Apr 25, 2019
@NickColley
Copy link
Contributor

I think it might be useful to be able to differentiate these from regular views in the title without having to read the source code.

NickColley
NickColley approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we talked on Slack, there's a few things we could improve about these pages so lets consider them separately when we have more time...

Nice work thanks Hanna 👍

@hannalaakso hannalaakso merged commit 22542c9 into master Apr 30, 2019
@hannalaakso hannalaakso deleted the create-legacy-template-view branch April 30, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickColley NickColley NickColley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hannalaakso @NickColley @36degrees @govuk-design-system-ci