Enable review app to include legacy styles #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These import the Elements and Frontend toolkit and enable the compatibility mode Co-authored-by: Oliver Byford <oliver.byford@digital.cabinet-office.gov.uk>
These are only required for the review app so excluding them if building for dist Co-authored-by: Oliver Byford <oliver.byford@digital.cabinet-office.gov.uk>
These stylesheets and scripts are included in generic.njk which is called by super() so including them again here is redundant Co-authored-by: Oliver Byford <oliver.byford@digital.cabinet-office.gov.uk>
Co-authored-by: Oliver Byford <oliver.byford@digital.cabinet-office.gov.uk>
aliuk2012
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
Its a pity we couldn't clean up the gulp task but we all agree its out of scope for this work and its already a bit weird.
👍 Great work @hannalaakso and @36degrees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored with @36degrees
This addresses the first part of #1262:
Also: